[helm chart] make image tag configurable #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ssudake21 @PrasadG193 should I address the changes suggested by rimusz in this PR (having appVersion in |
|
We can address those in the same PR |
- Add appVersion field to Chart.yaml. Thanks to @rimusz for the suggestions about this - If image.tag is set in values.yaml then that tag is used, otherwise falls back to appVersion from Chart.yaml - This makes easy to deploy images tagged with different names which are not according to sem ver 2 i.e. 'latest' or other valid container image tags Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
bhavin192
requested review from
sanketsudake and
PrasadG193
and removed request for
sanketsudake
Merged
sanketsudake
approved these changes
May 13, 2019
PrasadG193
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
falls back to Chart version
are not according to sem ver 2 i.e. 'latest' or other valid
container image tags
fixes #88