Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new event type "error" in config to watch error events on a resource #98

Merged
merged 5 commits into from
Jun 4, 2019
Merged

Add new event type "error" in config to watch error events on a resource #98

merged 5 commits into from
Jun 4, 2019

Conversation

PrasadG193
Copy link
Collaborator

@PrasadG193 PrasadG193 commented Jun 3, 2019 •
edited
Loading

  • Add new event type "error" in config to watch error events on a resource
  • Update README and BotKube architecture image
  • Use go1.12 for CI builds

Fixes #96

@PrasadG193 PrasadG193 changed the title Add error config Add new field "error" in resource level config to watch error events on the resource Jun 3, 2019
@PrasadG193 PrasadG193 changed the title Add new field "error" in resource level config to watch error events on the resource Add new event type "error" in config to watch error events on a resource Jun 3, 2019
sanketsudake
sanketsudake reviewed Jun 4, 2019
View reviewed changes
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/controller/controller.go Outdated Show resolved Hide resolved
pkg/utils/utils.go Show resolved Hide resolved
@PrasadG193 PrasadG193 merged commit 56c947e into kubeshop:develop Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake sanketsudake approved these changes

Assignees

@sanketsudake sanketsudake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "error" option to resource level BotKube config
2 participants
@PrasadG193 @sanketsudake