Added test case with mock server #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PrasadG193 , reminder for review. |
PrasadG193
reviewed
Sep 15, 2020
|
Hey @coupa-sbawaskar The PR looks great. Thanks for providing an example. There are few checks which are missing. |
sbawaskar
force-pushed
the
develop
branch
2 times, most recently
from
d80c5ba to
0e6e564
Compare
Added missing checks, please review. |
PrasadG193
reviewed
Sep 15, 2020
PrasadG193
reviewed
Sep 16, 2020
sbawaskar
force-pushed
the
develop
branch
2 times, most recently
from
e32bd39 to
9329beb
Compare
PrasadG193
reviewed
Sep 16, 2020
PrasadG193
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test case tests bot framework through http. Mock server is added to test http routes. This is a potential solution for #46.