Expose telemetry & crash reporting in helm (#493)

* expose telemetry & crash reporting in helm * address feedback
infrahq · Oct 20, 2021 · 287f0ec · 287f0ec
1 parent 4690827
commit 287f0ec
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 2 deletions.
diff --git a/helm/charts/registry/templates/deployment.yaml b/helm/charts/registry/templates/deployment.yaml
@@ -32,7 +32,20 @@ spec:
         - name: registry
           image: {{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}
           imagePullPolicy: {{ .Values.image.pullPolicy }}
-          args: ["registry", "-c", "/var/run/infra/config/infra.yaml", "--db", "/var/run/infra/data/infra.db", "--tls-cache", "/var/run/infra/data/cache"]
+          args:
+            - "registry"
+            - "-c"
+            - "/var/run/infra/config/infra.yaml"
+            - "--db"
+            - "/var/run/infra/data/infra.db"
+            - "--tls-cache"
+            - "/var/run/infra/data/cache"
+{{- if .Values.telemetry.enabled }}
+            - "--enable-telemetry"
+{{ end }}
+{{- if .Values.crashReporting.enabled }}
+            - "--enable-crash-reporting"
+{{ end }}
           env:
             - name: INFRA_REGISTRY_ROOT_API_KEY
               valueFrom:

diff --git a/helm/charts/registry/values.yaml b/helm/charts/registry/values.yaml
@@ -5,6 +5,12 @@ config: null
 pod:
   annotations: {}
 
+telemetry:
+  enabled: true
+
+crashReporting:
+  enabled: true
+
 serviceAccount:
   create: true
   annotations: {}

diff --git a/internal/registry/telemetry.go b/internal/registry/telemetry.go
@@ -19,8 +19,10 @@ func NewTelemetry(db *gorm.DB) (*Telemetry, error) {
 		return nil, errors.New("db cannot be nil")
 	}
 
+	enabled := internal.TelemetryWriteKey != ""
+
 	return &Telemetry{
-		enabled: true,
+		enabled: enabled,
 		client:  analytics.New(internal.TelemetryWriteKey),
 		db:      db,
 	}, nil