Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: k8s connector: allow disabling provider-name prefixing on users #1370

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

ssoroka
Copy link
Contributor

@ssoroka ssoroka commented Mar 28, 2022

Summary

See #1367. allow disabling prefixing of user emails in k8s. okta:joe@example.com to become joe@example.com. Assists with users managing their own authorization.

Checklist

  • Wrote appropriate unit tests
  • Considered security implications of the change
  • Updated associated docs where necessary
  • Updated associated configuration where necessary
  • Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
  • Nothing sensitive logged
  • Commit message conforms to Conventional Commit
  • GitHub Actions are passing
  • Considered data migrations for smooth upgrades

Related Issues

Resolves #1367

Copy link
Collaborator

@mxyng mxyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can potentially remove prefixing entirely. It was originally added to differentiate infra-created [cluster] role bindings from existing [cluster] role bindings. Since that's no longer necessary, removing it should be a consideration.

TLSCert string `mapstructure:"tlsCert"`
TLSKey string `mapstructure:"tlsKey"`
SkipTLSVerify bool `mapstructure:"skipTLSVerify"`
DisableProviderNamePrefix bool `mapstructure:"disableProviderNamePrefix"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we'd want to add a flag here since the user will need to know to do this for every connector. Wouldn't it make more sense to just remove infra:<provider> from the impersonation header?

On second thought, should we just remove the prefixes altogether? We don't add them for groups right now, and while it's an extra layer of security we may want to instead revisit this with #1286

@ssoroka ssoroka merged commit 28e404a into main Mar 29, 2022
@ssoroka ssoroka deleted the k8s-provider-prefix branch March 29, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8s connector: allow disabling provider-name prefixing on users
3 participants