fix: access key extension and deadline no longer optional #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add default value to access key ttl and extension deadline in the CLI - fix keys add command flags to be optional - fix destinations add command to have a default extension deadline
BruceMacD
commented
Mar 29, 2022
| if err != nil { | ||
| return err | ||
| deadline := 1 * time.Hour | ||
| if options.ExtensionDeadline != "" { |
There was a problem hiding this comment.
These are flags so they should be optional, set some safe defaults
mxyng
reviewed
Mar 29, 2022
ssoroka
approved these changes
Mar 29, 2022
- add note about the default ttl and deadline values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the process of migrating to a standard time format the extension deadline and time to live of access keys created through the API became required fields. Update to set defaults in the CLI rather than the API.
Checklist
Related Issues
Resolves #1385