feat: set telemetry events #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxyng
reviewed
Mar 31, 2022
internal/server/errors.go
Outdated
| @@ -66,6 +66,8 @@ func sendAPIError(c *gin.Context, err error) { | |||
| logging.WrappedSugarLogger(c).Errorw(err.Error(), "statusCode", resp.Code) | |||
| } | |||
|
|
|||
| a.t.Event(c, "error", Properties{"code": resp.Code}) | |||
There was a problem hiding this comment.
Would this have context of what errored?
There was a problem hiding this comment.
+1, maybe just the endpoint
There was a problem hiding this comment.
Not sure we need this for telemetry, since it will error for every single (expected) error as well
There was a problem hiding this comment.
changing this to only record for status code >= 500
BruceMacD
reviewed
Mar 31, 2022
internal/server/errors.go
Outdated
| @@ -66,6 +66,8 @@ func sendAPIError(c *gin.Context, err error) { | |||
| logging.WrappedSugarLogger(c).Errorw(err.Error(), "statusCode", resp.Code) | |||
| } | |||
|
|
|||
| a.t.Event(c, "error", Properties{"code": resp.Code}) | |||
There was a problem hiding this comment.
+1, maybe just the endpoint
BruceMacD
approved these changes
Apr 8, 2022
| if err != nil { | ||
| return err | ||
| switch track := track.(type) { | ||
| case analytics.Track: |
There was a problem hiding this comment.
Can do an if statement here and get rid of the duplication
There was a problem hiding this comment.
can't. it's a reflection thing where track assumes the type of the case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Related Issues
Resolves #1285