Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete grants on user delete #1447

Merged
merged 2 commits into from
Apr 4, 2022
Merged

fix: delete grants on user delete #1447

merged 2 commits into from
Apr 4, 2022

Conversation

BruceMacD
Copy link
Collaborator

@BruceMacD BruceMacD commented Apr 1, 2022

  • when an identity is deleted remove their grants also
  • test refactoring

Summary

When a user is deleted through the API we should also clean up their grants. Otherwise they hang around and cause errors when the CLI tries to look up the subject of these grants.

Checklist

  • Wrote appropriate unit tests
  • Considered security implications of the change
  • Updated associated docs where necessary
  • Updated associated configuration where necessary
  • Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
  • Nothing sensitive logged
  • Commit message conforms to Conventional Commit
  • GitHub Actions are passing
  • Considered data migrations for smooth upgrades

Related Issues

Resolves #1439

- when an identity is deleted remove their grants also
- test refactoring
@BruceMacD BruceMacD changed the title fix: delete a grants on user delete fix: delete grants on user delete Apr 1, 2022
@BruceMacD BruceMacD merged commit 26cb088 into main Apr 4, 2022
@BruceMacD BruceMacD deleted the grant_cleaning branch April 4, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove grants when users are removed
2 participants