maintain!: remove ununsed create token body (#1216)

[BruceMacD]

• remove unused create token request body that specified user id

Summary

The token creation endpoint took a user identifier in the request body, but this value is ignored. The token is created for the authorized party calling the endpoint.

This change means the CLI version will need to be upgraded.

Checklist

• Wrote appropriate unit tests
• Considered security implications of the change
• Updated associated docs where necessary
• Updated associated configuration where necessary
• Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
• Nothing sensitive logged
• Commit message conforms to Conventional Commit
• GitHub Actions are passing
• Considered data migrations for smooth upgrades

Related Issues

Resolves #1216

[dnephin]

Nice cleanup!

I guess api.CreateTokenRequest can also be removed now? Nothing references it.

Should we allow admins to create tokens for machine users? Or would we have them login as the machine user first and create the token that way? Not for this PR, but wondering how it interacts with the removal of infra destinations add.

[mxyng]

We should already have support for user identities creating machine identity access keys. The removal of destinations add relies on this

[dnephin]

Ah, sorry, I was confused! This is CreateToken, not CreateAccessKey. I got them mixed up.

[mxyng]

Easy thing to mix up 😞