feat: infra view role

[BruceMacD]

• allow identities with the view role read-only access to server state

Summary

There should be a way to audit the state of infra. Add a "view" role to enable this.

Also added some specific role checking tests in passing.

Checklist

• Wrote appropriate unit tests
• Considered security implications of the change
• Updated associated docs where necessary
• Updated associated configuration where necessary
• Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
• Nothing sensitive logged
• Commit message conforms to Conventional Commit
• GitHub Actions are passing
• Considered data migrations for smooth upgrades

Related Issues

Resolves #1505

[BruceMacD]

This doesn't output the key secrets. Only key names, expires and who they were issued for.

[mxyng]

I feel like with this role, we don't need the infra user role. The default could be either no role for new user where they can only access they resources they own, the view role where they can view but not edit all resources, and admin where they have full access to all resource. Thoughts?

[BruceMacD]

I feel like with this role, we don't need the infra user role. The default could be either no role for new user where they can only access they resources they own, the view role where they can view but not edit all resources, and admin where they have full access to all resource. Thoughts?

Yeah, getting rid of the user role is definitely ideal. I think we should do with something like #1084, the destinations grant checks will be needed.