fix: validate key names dont have spaces (#1449)

[BruceMacD]

• validate key names dont have spaces
• migrate existing keys with spaces
• validate key name in CLI before create

Summary

Working with access keys that have spaces in the name in the CLI is a pain. Fix this by not allowing spaces in the access key name.

Checklist

• Wrote appropriate unit tests
• Considered security implications of the change
• Updated associated docs where necessary
• Updated associated configuration where necessary
• Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
• Nothing sensitive logged
• Commit message conforms to Conventional Commit
• GitHub Actions are passing
• Considered data migrations for smooth upgrades

Related Issues

Resolves #1449

[dnephin]

Nice! This definitely addresses the most common case. I think we would have the same problem with any other whitespace characters, right? (tab, vertical tab, newline, carriage return, etc).

I wonder if there is a way to restrict the characters to only "visible" characters. Anything that returns true for https://pkg.go.dev/unicode#IsSpace should probably be invalid.

Not blocking, but maybe something for us to investigate later.