Remove sqlite support #3084
Remove sqlite support #3084
Conversation
dnephin
requested review from
BruceMacD,
jmorganca,
pdevine and
kimskimchi
as code owners
| case !ok && isEnvironmentCI: | ||
| t.Fatal("CI must test all drivers, set POSTGRESQL_CONNECTION") | ||
| case !ok: | ||
| t.Skip("Set POSTGRESQL_CONNECTION to test against postgresql") |
There was a problem hiding this comment.
So many of our tests rely on this I wonder if we should always fail without it
There was a problem hiding this comment.
The tests for our main interfaces (CLI, API, config) do all rely on a database, but there are plenty of tests for internal things that do not. It's easy to change, but I think it can be nice to let people run tests with minimal setup.
| @@ -646,6 +647,8 @@ type testCaseLabel struct { | |||
| Line string | |||
| } | |||
|
|
|||
| var isEnvironmentCI = os.Getenv("CI") != "" | |||
There was a problem hiding this comment.
Should this variable live closer to there it is used? I dont see it in migrations_test.go
There was a problem hiding this comment.
It's used 6 lines below here. The diff looks weird because I removed it from a different place in the data package.
This removes sqlite support.
Previously it was in a different place because we wanted different behaviour for the data package vs other packages. Now that we don't support sqlite we can use the same behaviour everywhere.
dnephin
force-pushed
the
dnephin/remove-sqlite-support
branch
from
b61e19d
to
29d1dd0
Compare
|
I pushed one more commit that removed a couple things I had missed:
Those changes allow us to remove our dependency on |
Summary
This PR removes sqlite support from both the server and tests. The server
--dbFileflag, and config file options will no longer do anything. From now on a postgreSQL database is required to run the server.In tests, if the
POSTGRESQL_CONNECTIONenvironment variable is set, the tests will run using that postgres instance. If it's not set in CI the tests will fail. If it's not set outside of CI (local development) any tests that require the database will be skipped.