Reduce verbosity in GenerateRoutes #3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can include route definitions from package-level variables, while keeping the route identifier (the method and path) as part of the call to add the route to a group.
So that GenerateRoutes reads clearly without having to skip over long route definitions.
dnephin
requested review from
ssoroka,
BruceMacD,
jmorganca and
pdevine
as code owners
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Most routes in
GenerateRoutesare added with a single. We have a few special cases that have to set fields on theroutedefinition, which makes them more verbose.This PR changes
addto accept themethodandpathseparate from theroutestruct. This allows us to move the route definition to a package-level variable, and keepGenerateRoutesto a single line per route.