use stronger algorithm defaults for certificates #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great stuff. Should we also update (OK in a separate PR) how we generate the certs we use to sign JWTs? infra/internal/registry/data.go Line 403 in e414cb7 |
jmorganca
approved these changes
Sep 25, 2021
|
hmm. this last change seems to break when I use it with prod, so I'm guessing it's not backwards compatible with what's currently in prod, or I missed something. I would really expect that I should be able to change the algorithm without breaking existing deployments. |
|
I do think this is unrelated, and worth trying now after rebasing :-) |
ssoroka
force-pushed
the
cert-algs
branch
3 times, most recently
from
ac0a132
to
59cf854
Compare
jmorganca
reviewed
Oct 6, 2021
internal/registry/api.go
Outdated
| @@ -136,6 +136,8 @@ func extractToken(context context.Context) (*Token, error) { | |||
| return nil, errors.New("token not found in context") | |||
| } | |||
|
|
|||
| // todo: should validate token? | |||
There was a problem hiding this comment.
This happens in line 100 (this function is really just for type casting!). That said, maybe the function naming / structure isn't the greatest if it looks naked without validation
jmorganca
reviewed
Oct 6, 2021
| @@ -779,3 +779,15 @@ func containsUser(users []api.User, email string) bool { | |||
|
|
|||
| return false | |||
| } | |||
|
|
|||
| func TestCredentials(t *testing.T) { | |||
jmorganca
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.