maintain: set dev version

[mxyng]

Summary

• Docker build without setting --build-arg=BUILDVERSION will produce version 99.99.99999
• go build or equivalent commands will produce version 99.99.99999 unless LDFLAGS are set
• CI sets RELEASE_NAME for artifact builds and BUILDVERSION for image builds so the version will be whatever is in those variables

Checklist

• Wrote appropriate unit tests
• Considered security implications of the change
• Updated associated docs where necessary
• Updated associated configuration where necessary
• Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
• Nothing sensitive logged
• Considered data migrations for smooth upgrades

Related Issues

Resolves #

[dnephin]

Nice! I like how this simplifies things.

Anything blocking merging this?

[mxyng]

Nothing in particular. It really depends if this addresses the problems @pdevine is trying to solve.

[pdevine]

I like the simplification in version.go. Can you modify the Makefile to remove the excess version lines at the top of it? Those are effectively useless right now.

I am slightly nervous about development getting weird versions, however I think it's pretty obvious that you're getting a bogus value with this change. The one thing it doesn't address is whether your gh repo is stale, although that's not entirely addressed by the other change either. On other projects I have worked on we have included something like: 18a3cd029d79f17 (stale) after the version which might be a nice addition to this.