Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only remove password reset scope on cred update #3429

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

BruceMacD
Copy link
Collaborator

Summary

When a credential is update the access key needs to have the "password reset required" scope removed, but keep the ability to create access keys. This change ensures that the key has the only the "password reset required scope" removed so any scopes we add in the future will also continue to work.

Checklist

  • Wrote appropriate unit tests
  • Considered security implications of the change
  • Updated associated docs where necessary
  • Updated associated configuration where necessary
  • Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
  • Nothing sensitive logged
  • Considered data migrations for smooth upgrades

Related Issues

Resolves #3348

Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BruceMacD BruceMacD merged commit 2023203 into main Oct 11, 2022
@BruceMacD BruceMacD deleted the brucemacd/reset_key_scopes branch October 11, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UpdateCredentials clears all access key scopes
2 participants