Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup timer a bit #378

Merged
merged 2 commits into from
Oct 5, 2021
Merged

cleanup timer a bit #378

merged 2 commits into from
Oct 5, 2021

Conversation

ssoroka
Copy link
Contributor

@ssoroka ssoroka commented Oct 1, 2021

No description provided.

jmorganca
jmorganca approved these changes Oct 2, 2021
View reviewed changes
Copy link
Contributor

@jmorganca jmorganca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

BruceMacD
BruceMacD reviewed Oct 4, 2021
View reviewed changes
internal/registry/registry.go
@@ -91,21 +92,23 @@ func Run(options Options) error {
}

// schedule the user and group sync jobs
interval := 30
interval := 30 * time.Second
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@ssoroka ssoroka merged commit be3f6f0 into main Oct 5, 2021
@ssoroka ssoroka deleted the timer branch October 5, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BruceMacD BruceMacD BruceMacD left review comments

@jmorganca jmorganca jmorganca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssoroka @jmorganca @BruceMacD