Simplify Helm install #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxyng
force-pushed
the
simplify-helm-install
branch
from
7c0ca0b
to
f7ecfd5
Compare
mxyng
commented
Oct 20, 2021
jmorganca
reviewed
Oct 20, 2021
jmorganca
reviewed
Oct 20, 2021
jmorganca
reviewed
Oct 20, 2021
docs/destinations/kubernetes.md
Outdated
| @@ -0,0 +1,44 @@ | |||
| ## Introduction | |||
There was a problem hiding this comment.
Love that you created the first of these!
jmorganca
reviewed
Oct 20, 2021
jmorganca
reviewed
Oct 20, 2021
jmorganca
reviewed
Oct 20, 2021
jmorganca
reviewed
Oct 20, 2021
jmorganca
reviewed
Oct 20, 2021
jmorganca
reviewed
Oct 20, 2021
jmorganca
reviewed
Oct 20, 2021
jmorganca
reviewed
Oct 20, 2021
jmorganca
reviewed
Oct 20, 2021
mxyng
force-pushed
the
simplify-helm-install
branch
4 times, most recently
from
4c0c147
to
dd8d861
Compare
BruceMacD
reviewed
Oct 20, 2021
README.md
Outdated
| - kind: role | ||
| name: viewer | ||
| destinations: | ||
| - name: <cluster name> |
There was a problem hiding this comment.
Maybe we can add a comment here to get the reader context around what the cluster name is
There was a problem hiding this comment.
that's initially why it set a static cluster name ("my-first-cluster"). I'm happy to add something if you have any suggestions
There was a problem hiding this comment.
I like the name being left out like this for clarity. What do you think of something like this?
destinations:
- name: <cluster name> # the cluster name can be set on deploying a new engine, otherwise it will default to the name of the cluster that the engine is running in
BruceMacD
reviewed
Oct 20, 2021
|
Are the empty |
jmorganca
reviewed
Oct 20, 2021
jmorganca
reviewed
Oct 20, 2021
| @@ -0,0 +1,34 @@ | |||
| ************************************************* | |||
jmorganca
reviewed
Oct 20, 2021
jmorganca
reviewed
Oct 20, 2021
jmorganca
reviewed
Oct 20, 2021
jmorganca
reviewed
Oct 20, 2021
no, they originally had content but it's no longer necessary |
mxyng
force-pushed
the
simplify-helm-install
branch
2 times, most recently
from
aaad674
to
3e6d8ab
Compare
jmorganca
reviewed
Oct 21, 2021
jmorganca
reviewed
Oct 21, 2021
jmorganca
reviewed
Oct 21, 2021
jmorganca
reviewed
Oct 21, 2021
mchiang0610
reviewed
Oct 21, 2021
mxyng
force-pushed
the
simplify-helm-install
branch
from
47b16bd
to
1a34888
Compare
mxyng
force-pushed
the
simplify-helm-install
branch
2 times, most recently
from
8bf8a17
to
ac786a6
Compare
mxyng
force-pushed
the
simplify-helm-install
branch
from
ac786a6
to
c970b62
Compare
mxyng
force-pushed
the
simplify-helm-install
branch
5 times, most recently
from
24b89e1
to
e96ca51
Compare
jmorganca
reviewed
Oct 21, 2021
README.md
Outdated
| * [Destinations](./docs/destinations) | ||
| * [Kubernetes](./docs/destinations/kubernetes.md) | ||
|
|
||
| ### Updating Infra |
There was a problem hiding this comment.
Nit/optional thing: should we call this "Upgrading?"
There was a problem hiding this comment.
Switched to Upgrade instead since there's no other -ing in this doc
mxyng
force-pushed
the
simplify-helm-install
branch
2 times, most recently
from
7677e9e
to
5ab61b3
Compare
jmorganca
approved these changes
Oct 21, 2021
mxyng
force-pushed
the
simplify-helm-install
branch
3 times, most recently
from
ca66a98
to
c340cc8
Compare
mxyng
force-pushed
the
simplify-helm-install
branch
from
c340cc8
to
1c26a85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two paradigm shifts are captured in this PR.
Auto-discover registry. If a registry host is not provided, the engine will try to query Kubernetes Services to find an appropriate host. This will use the new label
infrahq.com/flavorto find a registry service.Both the registry and engine has been updated to accept URIs for secrets, right now root API key and engine API key. The services themselves will resolve this reference to actual values. Implementation will vary.
For now, the only support format is
file://which will look for the secrets in the filesystem at the path provided. In the future, this can be used to get secrets from Vault, AWS KMS, whatever else.These changes combined allows a fully functional Infra deploy using a single
infraHelm chart.TODO:
image.tag,image.pullPolicy, etc.Fixes #465
Fixes #484