rename registry to infra #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BruceMacD
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
Thanks for going through the pain of doing this.
It all looks in order to me, my one piece of feedback is that I'd personally rather the infra/internal/registry directory was re-named infra/internal/server rather than nesting the name again infra/internal/infra. Just an opinion though.
jmorganca
reviewed
Oct 26, 2021
mchiang0610
force-pushed
the
registry-name
branch
from
cbd17aa
to
15cc818
Compare
jmorganca
approved these changes
Oct 26, 2021
mchiang0610
force-pushed
the
registry-name
branch
from
097276b
to
efd99e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.