Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manually post process after openapi-cli generator #531

Merged
merged 2 commits into from
Oct 26, 2021
Merged

manually post process after openapi-cli generator #531

merged 2 commits into from
Oct 26, 2021

Conversation

mxyng
Copy link
Collaborator

@mxyng mxyng commented Oct 26, 2021

For some reason, openapi-generator doesn't want to run post processing for internal/api/*.go, so called supporting files, on code generation.

jmorganca
jmorganca approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@jmorganca jmorganca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! openapi-generator does have a few quirks

BruceMacD
BruceMacD approved these changes Oct 26, 2021
View reviewed changes
Copy link
Collaborator

@BruceMacD BruceMacD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed it works on Mac OS also 👍

@mxyng mxyng merged commit 19f9301 into main Oct 26, 2021
@mxyng mxyng deleted the manual-post-processing branch October 26, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BruceMacD BruceMacD BruceMacD approved these changes

@jmorganca jmorganca jmorganca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxyng @jmorganca @BruceMacD