-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source restructure #532
Merged
Merged
Source restructure #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxyng
reviewed
Oct 26, 2021
mxyng
reviewed
Oct 26, 2021
mxyng
reviewed
Oct 26, 2021
jmorganca
reviewed
Oct 27, 2021
BruceMacD
force-pushed
the
source-restructure
branch
from
October 27, 2021 14:40
dd097cf
to
6ee0c0b
Compare
BruceMacD
force-pushed
the
source-restructure
branch
from
October 27, 2021 19:35
6ad28cc
to
401fc64
Compare
mxyng
reviewed
Oct 27, 2021
jmorganca
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after revisiting @mxyng 's comments on serialize
and deserialize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #519
Iteration for: #435
Next steps:
#518 - rename source to providers
#244 - adding the config migrator at the same time as the provider change to reduce the amount of config versions
#435 - add the provider CRUD endpoints
Changes:
Sources now have this structure:
This will allow for a repeatable structure in the future as we only support the auth code flow at this time. For example another custom IDP called
some-idp
may look like this: