New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

models: use partial index for unique constraints #736

Merged

mxyng merged 1 commit into main from composite-index

Dec 10, 2021

Collaborator

mxyng commented Dec 10, 2021 •

edited

Loading

Allow soft deletes while keeping unique constraints by creating an unique index using both deleted_at and the tables' unique field.

Wrote appropriate unit tests
Considered security implications of the change
Updated associated docs where necessary
Updated associated configuration where necessary
Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
Nothing sensitive logged

Resolves #

mxyng mentioned this pull request

Create or update root/engine tokens on start-up #733

Merged

6 tasks

ssoroka approved these changes

View reviewed changes


          models: add composite unique index

403d82e

mxyng changed the title ~~models: add composite unique index~~ models: use partial index for unique constraints

mxyng force-pushed the composite-index branch from 69255be to 403d82e Compare

December 10, 2021 20:45

Contributor

jmorganca commented Dec 10, 2021

Nice catch!

mxyng merged commit e958fbd into main

mxyng deleted the composite-index branch

December 10, 2021 20:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet