Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dive to validate config structs #873

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Dive to validate config structs #873

merged 1 commit into from
Feb 2, 2022

Conversation

BruceMacD
Copy link
Collaborator

In order for all config fields to be validated on initialization the validation needs these dive flags on fields.

  • Wrote appropriate unit tests
  • Considered security implications of the change
  • Updated associated docs where necessary
  • Updated associated configuration where necessary
  • Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
  • Nothing sensitive logged

@jmorganca
Copy link
Contributor

Great catch! 💯

@BruceMacD BruceMacD merged commit 1cf5d7d into main Feb 2, 2022
@BruceMacD BruceMacD deleted the dive branch February 2, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants