Update workflows (#607)

## Describe the changes This PR: - Remove v3 branch for workflows - fix golang workflow to run on cpp changes - remove unneeded token for checking out backend - add conditional for checking out backend
ingonyama-zk · Sep 9, 2024 · d6c0034 · d6c0034
1 parent c5fec85
commit d6c0034
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 21 deletions.
diff --git a/.github/workflows/codespell.yml b/.github/workflows/codespell.yml
@@ -4,7 +4,6 @@ on:
   pull_request:
     branches:
       - main
-      - V3
 
 jobs:
   spelling-checker:

diff --git a/.github/workflows/cpp.yml b/.github/workflows/cpp.yml
@@ -3,11 +3,9 @@ name: C++/CUDA
 on:
   pull_request:
     branches:
-      - V3
       - main
   push:
     branches:
-      - V3
       - main
 
 concurrency:
@@ -56,11 +54,11 @@ jobs:
     - name: Checkout Repo
       uses: actions/checkout@v4
     - name: Checkout CUDA Backend
+      if: needs.check-changed-files.outputs.cpp == 'true'
       uses: actions/checkout@v4
       with:
         repository: ingonyama-zk/icicle-cuda-backend
         path: ./icicle/backend/cuda
-        token: ${{ secrets.GITHUB_TOKEN }}
         ssh-key: ${{ secrets.CUDA_PULL_KEY }}
         ref: ${{ needs.extract-cuda-backend-branch.outputs.cuda-backend-branch }}
     - name: Build curve
@@ -92,11 +90,11 @@ jobs:
     - name: Checkout Repo
       uses: actions/checkout@v4
     - name: Checkout CUDA Backend
+      if: needs.check-changed-files.outputs.cpp == 'true'
       uses: actions/checkout@v4
       with:
         repository: ingonyama-zk/icicle-cuda-backend
         path: ./icicle/backend/cuda
-        token: ${{ secrets.GITHUB_TOKEN }}
         ssh-key: ${{ secrets.CUDA_PULL_KEY }}
         ref: ${{ needs.extract-cuda-backend-branch.outputs.cuda-backend-branch }}
     - name: Build field

diff --git a/.github/workflows/deploy-docs.yml b/.github/workflows/deploy-docs.yml
@@ -4,7 +4,6 @@ on:
   push:
     branches:
       - main
-      - V3
     paths:
       - 'docs/**'
 

diff --git a/.github/workflows/examples.yml b/.github/workflows/examples.yml
@@ -9,11 +9,9 @@ name: Examples
 on:
   pull_request:
     branches:
-      - V3
       - main
   push:
     branches:
-      - V3
       - main
 
 concurrency:
@@ -40,7 +38,6 @@ jobs:
       with:
         repository: ingonyama-zk/icicle-cuda-backend
         path: ./icicle/backend/cuda
-        token: ${{ secrets.GITHUB_TOKEN }}
         ssh-key: ${{ secrets.CUDA_PULL_KEY }}
         ref: ${{ needs.extract-cuda-backend-branch.outputs.cuda-backend-branch }}
     - name: c++ examples

diff --git a/.github/workflows/golang.yml b/.github/workflows/golang.yml
@@ -3,11 +3,9 @@ name: GoLang
 on:
   pull_request:
     branches:
-      - V3
       - main
   push:
     branches:
-      - V3
       - main
 
 concurrency:
@@ -59,11 +57,11 @@ jobs:
     - name: Checkout Repo
       uses: actions/checkout@v4
     - name: Checkout CUDA Backend
+      if: needs.check-changed-files.outputs.golang == 'true' || needs.check-changed-files.outputs.cpp == 'true'
       uses: actions/checkout@v4
       with:
         repository: ingonyama-zk/icicle-cuda-backend
         path: ./icicle/backend/cuda
-        token: ${{ secrets.GITHUB_TOKEN }}
         ssh-key: ${{ secrets.CUDA_PULL_KEY }}
         ref: ${{ needs.extract-cuda-backend-branch.outputs.cuda-backend-branch }}
     - name: Setup go
@@ -72,13 +70,13 @@ jobs:
         go-version: '1.20.0'
     - name: Build
       working-directory: ./wrappers/golang
-      if: needs.check-changed-files.outputs.golang == 'true' || needs.check-changed-files.outputs.cpp_cuda == 'true'
+      if: needs.check-changed-files.outputs.golang == 'true' || needs.check-changed-files.outputs.cpp == 'true'
       # builds a single curve with the curve's specified build args
       run: |
         ./build.sh -curve=${{ matrix.curve.name }} ${{ matrix.curve.build_args }} -cuda_backend=local
     - name: Test
       working-directory: ./wrappers/golang/curves
-      if: needs.check-changed-files.outputs.golang == 'true' || needs.check-changed-files.outputs.cpp_cuda == 'true'
+      if: needs.check-changed-files.outputs.golang == 'true' || needs.check-changed-files.outputs.cpp == 'true'
       run: |
         CURVE=$(echo ${{ matrix.curve.name }} | sed -e 's/_//g')
         export ICICLE_BACKEND_INSTALL_DIR=/usr/local/lib
@@ -97,11 +95,11 @@ jobs:
     - name: Checkout Repo
       uses: actions/checkout@v4
     - name: Checkout CUDA Backend
+      if: needs.check-changed-files.outputs.golang == 'true' || needs.check-changed-files.outputs.cpp == 'true'
       uses: actions/checkout@v4
       with:
         repository: ingonyama-zk/icicle-cuda-backend
         path: ./icicle/backend/cuda
-        token: ${{ secrets.GITHUB_TOKEN }}
         ssh-key: ${{ secrets.CUDA_PULL_KEY }}
         ref: ${{ needs.extract-cuda-backend-branch.outputs.cuda-backend-branch }}
     - name: Setup go
@@ -110,13 +108,13 @@ jobs:
         go-version: '1.20.0'
     - name: Build
       working-directory: ./wrappers/golang
-      if: needs.check-changed-files.outputs.golang == 'true' || needs.check-changed-files.outputs.cpp_cuda == 'true'
+      if: needs.check-changed-files.outputs.golang == 'true' || needs.check-changed-files.outputs.cpp == 'true'
       # builds a single field with the fields specified build args
       run:  |
         ./build.sh -field=${{ matrix.field.name }} ${{ matrix.field.build_args }} -cuda_backend=local
     - name: Test
       working-directory: ./wrappers/golang/fields
-      if: needs.check-changed-files.outputs.golang == 'true' || needs.check-changed-files.outputs.cpp_cuda == 'true'
+      if: needs.check-changed-files.outputs.golang == 'true' || needs.check-changed-files.outputs.cpp == 'true'
       run: |
         FIELD=$(echo ${{ matrix.field.name }} | sed -e 's/_//g')
         export ICICLE_BACKEND_INSTALL_DIR=/usr/local/lib

diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
@@ -3,11 +3,9 @@ name: Rust
 on:
   pull_request:
     branches:
-      - V3
       - main
   push:
     branches:
-      - V3
       - main
 
 concurrency:
@@ -48,11 +46,11 @@ jobs:
     - name: Checkout Repo
       uses: actions/checkout@v4
     - name: Checkout CUDA Backend
+      if: needs.check-changed-files.outputs.rust == 'true' || needs.check-changed-files.outputs.cpp == 'true'
       uses: actions/checkout@v4
       with:
         repository: ingonyama-zk/icicle-cuda-backend
         path: ./icicle/backend/cuda
-        token: ${{ secrets.GITHUB_TOKEN }}
         ssh-key: ${{ secrets.CUDA_PULL_KEY }}
         ref: ${{ needs.extract-cuda-backend-branch.outputs.cuda-backend-branch }}
     - name: Run tests

diff --git a/.github/workflows/test-deploy-docs.yml b/.github/workflows/test-deploy-docs.yml
@@ -4,7 +4,6 @@ on:
   pull_request:
     branches:
       - main
-      - V3
     paths:
       - 'docs/**'