Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

precompute bug fix #529

Merged
merged 1 commit into from
May 29, 2024
Merged

precompute bug fix #529

merged 1 commit into from
May 29, 2024

Conversation

HadarIngonyama
Copy link
Contributor

This PR fixes 2 things:

  1. Removes the assertion regarding the precompute factor needing to be a power of 2. There is no such requirement and it works just fine for other values too.
  2. Fixes the average bucket size for the large buckets threshold - it depends on the precompute factor.

@jeremyfelder
Copy link
Collaborator

Merging with the failed spell check since it will be fixed in #528

@jeremyfelder jeremyfelder merged commit 417ca77 into main May 29, 2024
25 of 26 checks passed
@jeremyfelder jeremyfelder deleted the msm/precomputation_fix branch May 29, 2024 10:59
@HadarIngonyama HadarIngonyama restored the msm/precomputation_fix branch May 29, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonam3e nonam3e nonam3e approved these changes

@yshekel yshekel yshekel approved these changes

@ChickenLover ChickenLover ChickenLover approved these changes

@DmytroTym DmytroTym Awaiting requested review from DmytroTym

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HadarIngonyama @jeremyfelder @ChickenLover @yshekel @nonam3e