Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube/Hide toolbar button): create button is not hidden on tablets #1568

Closed
5 tasks done
girshcatt opened this issue Oct 19, 2023 · 6 comments
Closed
5 tasks done
Labels
Bug report Something isn't working

Comments

@girshcatt
Copy link

Type

Error at runtime

Tools used

Revancify

Application

YouTube 18.24.37 ~ 18.39.41

Bug description

On tablets create toolbar button can't be hidden

Steps to reproduce

1.Include Hide toolbar button patch
2.Switch navigation buttons
3.Hide toolbar button
4(Optionally).Turn on tablet layout if you on phone

Relevant log output

:/

Screenshots or videos

Screenshot_20231019_173247_ReVanced Extended
Screenshot_20231019_173403_ReVanced Extended

Solution

For this time i can only turn on phone layout(

Additional context

Similarly as #1567 bug can be reproduced on any phone just by turning on tablet layout

Device Environment

Galaxy Tab S6: Android 12, One Ui 4.1.1

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • I have written the title and contents in English.
  • This issue does not reproduce on unpatched YouTube or YT Music.
@girshcatt girshcatt added the Bug report Something isn't working label Oct 19, 2023
@Sam101011
Copy link

Having the same bug on my phone(Huawei P40 lite), so it's not tablet limited bug. Was gonna open an issue on my own(literally did the screen recording), but this one pretty much covers it.

From the testing I did, it looks like it's conflicting with the 'switch-create-notification' patch. If inotia decides my recording could be of any use, I'll open a seperate issue.

@inotia00
Copy link
Owner

Please upload screenshot

@Sam101011
Copy link

https://mega.nz/file/hWNF0AhI#fRWO4gS6ltbovrnfV3B2s9mFJfMN56dY7YHVb2ZTIIs

Providing mega link cuz GH doesn't allow uploads larger than 10mb

@inotia00
Copy link
Owner

Providing mega link cuz GH doesn't allow uploads larger than 10mb

Create button is not hidden right?

@Sam101011
Copy link

Providing mega link cuz GH doesn't allow uploads larger than 10mb

Create button is not hidden right?

Yes, tho it looks like it gets hidden for a brief moment, before showing up again.

@inotia00 inotia00 changed the title bug(YouTube/Hide toolbar button): on tablets create toolbar button can't be hidden bug(YouTube/Hide toolbar button): create button is not hidden on tablets Oct 20, 2023
@inotia00
Copy link
Owner

fixed in revanced-patches-v2.195.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants