Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion(YouTube/Force video codec): separate the patch that spoofs device dimensions from the Force video codec patch #1582

Closed
5 tasks done
eldepor opened this issue Oct 20, 2023 · 5 comments
Labels
Suggestion Leave any other suggestions

Comments

@eldepor
Copy link

eldepor commented Oct 20, 2023

Application

YouTube

Description

Any chance of including this new patch? It solves the issue described in my comments here, here and here. Force codec patch does not solve it.

Thanks.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • This is not a feature request for YouTube.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • I have written the title and contents in English.
@eldepor eldepor added the Suggestion Leave any other suggestions label Oct 20, 2023
@inotia00
Copy link
Owner

Already exists in RVX patch
The Force video codec patch does the same thing

@eldepor
Copy link
Author

eldepor commented Oct 20, 2023

It doesn't, as I explained in detail above. Force video codec patch just "unlocks" higher resolutions not shown by default, but it doesn't prevent the quality drop issue I mentioned in the thread, please read it if you don't mind.

Check this video, I have set the same RV/RVX quality settings in both cases (highest quality and 1080p on default wifi videos, trying other settings gives same results). Look stats and quality menu marked with the red rectangle. 720 and 1080 just dissapear after 480 drop

video_2023-10-21_00-24-48.mp4

This doesnt happen with spoof device dimensions patch, no resolution drop and stays in 1080p60

video_2023-10-21_00-28-01_edit.mp4

Same with shorts.

@inotia00
Copy link
Owner

The Force video codec patch also has the same function, but the Force video codec patch not only spoofs the dimensions, but also spoofs the model name and manufacturer.

This is probably the cause of the issue

It seems more appropriate to remove the part that spoofs dimensions from the Force video codec patch and separate it into the Spoof device dimensions patch.

@inotia00 inotia00 changed the title suggestion: <new spoof device dimensions patch>: suggestion(YouTube/Force video codec): Separate the patch that spoofs device dimensions from the Force video codec patch Oct 21, 2023
@inotia00 inotia00 reopened this Oct 21, 2023
@inotia00 inotia00 changed the title suggestion(YouTube/Force video codec): Separate the patch that spoofs device dimensions from the Force video codec patch suggestion(YouTube/Force video codec): separate the patch that spoofs device dimensions from the Force video codec patch Oct 21, 2023
@inotia00
Copy link
Owner

reflected in revanced-patches-v2.195.1

@eldepor
Copy link
Author

eldepor commented Oct 21, 2023

Thanks man for the separate patches, looks like issue is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggestion Leave any other suggestions
Projects
None yet
Development

No branches or pull requests

2 participants