Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: Ability to toggle multiple options in Hide settings menu patch without being prompted to restart client each time #2423

Open
3 of 5 tasks
Rairof opened this issue Oct 6, 2024 · 6 comments
Labels
Suggestion Leave any other suggestions

Comments

@Rairof
Copy link

Rairof commented Oct 6, 2024

Application

YouTube

Suggestion description

For convenience, it would be better to let users select multiple options inside Hide settings menu category instead of having a prompt to restart client each time a toggle is changed.

My suggestion- The pop up only appears after we toggle the required options and go back (press the back button or icon on top left) or click on "done" button on top right or something similar.
Screenshot_20241007-030402_YouTube
Screenshot_20241007-030749_YouTube Music

Acknowledgements

  • This issue is not a duplicate of an existing suggestion.
  • This is not a feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@Rairof Rairof added the Suggestion Leave any other suggestions label Oct 6, 2024
@Rairof Rairof changed the title suggestion: Ability to toggle multiple options in Hide settings menu patch suggestion: Ability to toggle multiple options in Hide settings menu patch without being prompted to restart client each time Oct 6, 2024
@GucekPL
Copy link

GucekPL commented Oct 7, 2024

But you can click ‘cancel’ or the area outside the dialogand only click ‘OK’ after selecting the last option you are interested in

@Rairof
Copy link
Author

Rairof commented Oct 8, 2024

#2423 (comment)
It works but it's annoying and inconvenient to do it for each and every toggle change.
It would be better if the pop up only appears after we toggled the required options and go back (press the back button/icon on top left) or click on "done" button on top right or something similar.

@federicogith
Copy link

One solution could be to have another option at the top that hides all the settings menus just like the "Hide quick actions container" option does with quick actions
Screenshot_20241026_163411_YouTube

@Rairof
Copy link
Author

Rairof commented Oct 26, 2024

#2423 (comment)
It's best to have individual options for each settings option to preserve the liberty of user's preferences on toggling whatever options they want.

@federicogith
Copy link

It's best to have individual options for each settings option to preserve the liberty of user's preferences on toggling whatever options they want.

What? Who said anything about removing the individual options 🫠
Just suggested to add an extra option at top that when enabled it hides all the setting menus
When it's disabled you can still choose which one to hide or see individually just like the screen above

@Rairof
Copy link
Author

Rairof commented Oct 26, 2024

#2423 (comment)
Having an option that hides all the setting menus isn't a solution to the proposed issue i.e the frequent restart pop ups.
It's best to just remove the restart pop up and promt it only when user triggers back gesture or clicks on the back button or have a "save" button to select after selecting relevant settings to hide then showing the restart pop up frequently after each toggle change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggestion Leave any other suggestions
Projects
None yet
Development

No branches or pull requests

3 participants