Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate elements-example-vue from Vue v2 to v3 #200

Closed
janivo opened this issue Nov 20, 2020 · 1 comment · Fixed by #554
Closed

Migrate elements-example-vue from Vue v2 to v3 #200

janivo opened this issue Nov 20, 2020 · 1 comment · Fixed by #554
Assignees
@BenPag
Labels
bug This issue describes something that isn't working as expected
Milestone
Next

Comments

@janivo
Copy link
Collaborator

janivo commented Nov 20, 2020 •
edited
Loading

Describe the bug

We have a vue example project which is currently based on Vue 2.x. Now that Vue 3 got released, we should also update our example project AND our migration guide to support both versions.

I made some first steps here: inovex/elements-example-vue#3

But there are still some issues to address:

  • Everything below the ino-button won't be displayed (maybe the way the attributes of the other components are used is deprecated?)
  • I had to use the beta version of the vue-loader in order to compile successfully (see Unable get rid of web component warning vuejs/core#1414 (comment)). Is there any other way to make it work?
  • Upgrade our integration guide to support both versions (in this repo)
@janivo janivo added bug This issue describes something that isn't working as expected high prio labels Nov 20, 2020
@janivo janivo changed the title vue: Migrate Example from V2 to V3 Migrate elements-example-vue from Vue v2 to v3 Nov 23, 2020
@BenPag BenPag self-assigned this May 28, 2021
@janivo
Copy link
Collaborator Author

janivo commented May 31, 2021 •
edited
Loading

closed by inovex/elements-example-vue#4

@janivo janivo closed this as completed May 31, 2021
@janivo janivo reopened this May 31, 2021
@silentHoo silentHoo added this to the Getting Started milestone Nov 12, 2021
@silentHoo silentHoo modified the milestones: Getting Started, Next Nov 25, 2021
@BenPag BenPag mentioned this issue Mar 8, 2022
Closed
5 tasks
@BenPag BenPag mentioned this issue Mar 15, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenPag BenPag

Labels
bug This issue describes something that isn't working as expected
Projects
None yet
Milestone
Next
Development

Successfully merging a pull request may close this issue.

feat(elements): add support for Vue3 inovex/elements
3 participants
@silentHoo @janivo @BenPag