You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Currently Tasks are added and executed in Command and on exception we stop the execution. But in some cases like in the SymlinkVipGoDir::run() we do not check for successful execution and continue with an errornous results. In other cases we continue the runner, but printing errors, like in DownloadWpCore:run(). We should generalize this and consider, that "critical execution" needs to 100% succeed or otherwhise throw an Exception to stop the program.
Describe the solution you'd like
Following Tasks need to be updated and throw a custom Exception when we cannot ensure that the task 100% completes:
Is your feature request related to a problem? Please describe.
Currently Tasks are added and executed in
Command
and on exception we stop the execution. But in some cases like in theSymlinkVipGoDir::run()
we do not check for successful execution and continue with an errornous results. In other cases we continue the runner, but printing errors, like inDownloadWpCore:run()
. We should generalize this and consider, that "critical execution" needs to 100% succeed or otherwhise throw an Exception to stop the program.Describe the solution you'd like
Following Tasks need to be updated and throw a custom Exception when we cannot ensure that the task 100% completes:
Command
?Additional context
See discussion here: #5
Just had a quick review yet..maybe we'll find more. Will update the list when i find one.
The text was updated successfully, but these errors were encountered: