Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks - handling of errors/exceptions in Task::run() #6

Open
6 tasks
Chrico opened this issue Mar 31, 2021 · 0 comments
Open
6 tasks

Tasks - handling of errors/exceptions in Task::run() #6

Chrico opened this issue Mar 31, 2021 · 0 comments
Milestone

Comments

@Chrico
Copy link
Member

Chrico commented Mar 31, 2021

Is your feature request related to a problem? Please describe.

Currently Tasks are added and executed in Command and on exception we stop the execution. But in some cases like in the SymlinkVipGoDir::run() we do not check for successful execution and continue with an errornous results. In other cases we continue the runner, but printing errors, like in DownloadWpCore:run(). We should generalize this and consider, that "critical execution" needs to 100% succeed or otherwhise throw an Exception to stop the program.

Describe the solution you'd like
Following Tasks need to be updated and throw a custom Exception when we cannot ensure that the task 100% completes:

Additional context
See discussion here: #5

Just had a quick review yet..maybe we'll find more. Will update the list when i find one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants