Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): tx error mapping fix #210

Merged
merged 1 commit into from
Mar 28, 2022
Merged

fix(core): tx error mapping fix #210

merged 1 commit into from
Mar 28, 2022

Conversation

iadmytro
Copy link
Contributor

Fixed mapping for core errors to Ogmios.

@iadmytro iadmytro requested a review from rhyslbw March 28, 2022 08:37
mkazlauskas
mkazlauskas previously approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@mkazlauskas mkazlauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

packages/core/test/Cardano/types/TxSubmissionErrors.test.ts Outdated Show resolved Hide resolved
@iadmytro iadmytro merged commit a03edcd into master Mar 28, 2022
@iadmytro iadmytro deleted the tx-errors-fix branch March 28, 2022 10:10
@rhyslbw
Copy link
Member

rhyslbw commented Mar 29, 2022

Well done @iadmytro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkazlauskas mkazlauskas mkazlauskas approved these changes

@rhyslbw rhyslbw Awaiting requested review from rhyslbw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iadmytro @rhyslbw @mkazlauskas