fix: the transaction id computation now accounts for serialization round trip errors #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhyslbw
requested changes
Jun 19, 2023
…tion round trip errors
rhyslbw
approved these changes
Jun 20, 2023
iadmytro
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Because of how CBOR works. There are multiple ways in CBOR to represent the same data. Unfortunately right now the CML doesn't maintain the serialization format upon using from_bytes so if cardano-cli uses non-canonical CBOR this will result in different hashes.
Proposed Solution
Maintain the original the serialized bytes of the body, and use that to compute the hash instead of re serializing (when possible).
Important Changes Introduced
Added a new method to the transaction class 'getId' which always compute the hash of the transaction body using the original bytes found in the transaction (if available). Please note that if changes to the transaction body are made, this cache will be invalidated.