Adding pphash and making hash to data map #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polinavino
force-pushed
the
polina/pphash
branch
4 times, most recently
from
da6b396 to
a49b709
Compare
nc6
requested changes
Jan 5, 2021
| data EraIndependentPP | ||
|
|
||
| -- Hash of a subset of Protocol Parameters relevant to Plutus script evaluation | ||
| newtype PPHash crypto |
There was a problem hiding this comment.
Please add this to a new module (maybe Cardano.Ledger.Alonzo.ProtocolParameters) rather than adding it to TxBody.
There was a problem hiding this comment.
There is already a PParams module in Alonzo, ok if I put it there?
| ToCBOR (TxOut era) | ||
| where | ||
| toCBOR (TxOutCompact addr cv dh) = | ||
| encode $ | ||
| Rec TxOutCompact !> To addr !> To cv !> To dh | ||
| Rec @(CompactAddr (Crypto era) -> CompactForm (Core.Value era) -> StrictMaybe (DataHash (Crypto era)) -> TxOut era) |
There was a problem hiding this comment.
Is this change really needed? I can't see anything in this PR which would precipitate it?
There was a problem hiding this comment.
changed the type application to CompactTxOut @era instead
| @@ -45,9 +46,10 @@ instance Arbitrary ExUnits where | |||
| arbitrary = ExUnits <$> arbitrary <*> arbitrary | |||
|
|
|||
| instance | |||
| ( Era era, | |||
| Mock (Crypto era), | |||
| ( ShelleyBased era, | |||
There was a problem hiding this comment.
We're trying to deprecate the various ShelleyBased constraints, so you should use the various UseFoo constraints as needed.
polinavino
force-pushed
the
polina/pphash
branch
from
a89e905 to
da2ba0d
Compare
nc6
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
TxBodyDataset inTxWitnessto a hash-indexed map