make TxOut a type family #2077
Merged
make TxOut a type family #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
commented
Dec 24, 2020
nc6
approved these changes
Jan 4, 2021
| withdrawals = unWdrl $ getField @"wdrls" txb | ||
| UTxO u'' = eval (dom (txinsScript (getField @"inputs" txb) u) ◁ u) |
There was a problem hiding this comment.
I don't understand what's going on here!
There was a problem hiding this comment.
OK, looks like domain restriction has some weird return-type polymorphism going on!
| ) => | ||
| HasField "address" (TxOut era) (Addr c) | ||
| where | ||
| getField (TxOut a _) = a |
There was a problem hiding this comment.
Add one of these for compact address
JaredCorduan
force-pushed
the
jc/make-txout-a-type-family
branch
from
5ea695b
to
4624a2f
Compare
The type TxOut will change for alonzo (it will include a Maybe DataHash)
JaredCorduan
force-pushed
the
jc/make-txout-a-type-family
branch
from
4624a2f
to
e78bbfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type
TxOutwill change for alonzo (it will include aMaybe DataHash), and this PR prepares the way.Note: before this can be merged, I need to re-enable the
ApplyBlock (MaryEra c)instance and figure out why the constraintNoThunks (CompactForm (Cardano.Ledger.Mary.Value.Value c))is now missing.