Functionality for Alonzo scripts, and fixed Fast forward problem. #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added operations on Scripts and TxBody in Aonzo. Mostly Figure 5 and 6 Also fixed the fast forward problem of merging the pretty printer on top of the change of TxBody to a type family.
JaredCorduan
reviewed
Jan 7, 2021
| data ScriptPurpose crypto | ||
| = Minting !(PolicyID crypto) | ||
| | Spending !(TxIn crypto) | ||
| | Rewarding !(RewardAcnt crypto) -- Not sure if this is the right type. |
There was a problem hiding this comment.
that is the correct type
JaredCorduan
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
It looks mostly great! We should keep the names the same between the spec and the code, though. Such as InputTag vs Spend in Tag. But since this PR fixes the problems in master (due to the non-fast-forward merge), I'm happy to get this in sooner rather than later, and change the names next.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added operations on Scripts and TxBody in Aonzo. Mostly Figure 5 and 6
Also fixed the fast forward problem of merging the pretty printer on
top of the change of TxBody to a type family.