-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrating Plutus in Ledger code #2127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
reviewed
Feb 8, 2021
JaredCorduan
reviewed
Feb 8, 2021
JaredCorduan
reviewed
Feb 8, 2021
JaredCorduan
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
nc6
approved these changes
Feb 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added NoThunks, ToCBOR, FromCBOR and Arbitrary instances. wrote a Pretty Printer, and ran all the serializations tests. Added a few useful Coders library functions for decoding Annotators for Lists and Sets
JaredCorduan
force-pushed
the
jc/import-plutus-ledger-api
branch
from
February 16, 2021 20:04
a50a6ac
to
49bcc1e
Compare
JaredCorduan
changed the title
WIP integrating Plutus in Ledger code
integrating Plutus in Ledger code
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jared, Alex and I, have gotten the Plutus package to compile with the Ledger code.
This required adjusting some nix-files, some cabal files, and altering the version requirements
of some of the dependencies.
To demonstrate this capability, I have integrated Language.PlutusTx.Data into Cardano.Alonzo.Data.
Wrote some instances, a pretty printer, and an Arbitrary instance. This might be a good place
to push back to master, as the changes touch very few files.
All seems to be working, except when I try to run the ormolise script, where I get this error message. Probably we did something bad to the nix files.