-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Pulsing to reward calculation (second try) #2142
Conversation
ab300bf
to
e00d862
Compare
shelley/chain-and-ledger/executable-spec/src/Shelley/Spec/Ledger/LedgerState.hs
Outdated
Show resolved
Hide resolved
shelley/chain-and-ledger/executable-spec/src/Shelley/Spec/Ledger/LedgerState.hs
Outdated
Show resolved
Hide resolved
shelley/chain-and-ledger/executable-spec/src/Shelley/Spec/Ledger/LedgerState.hs
Outdated
Show resolved
Hide resolved
shelley/chain-and-ledger/executable-spec/src/Shelley/Spec/Ledger/LedgerState.hs
Outdated
Show resolved
Hide resolved
shelley/chain-and-ledger/executable-spec/src/Shelley/Spec/Ledger/LedgerState.hs
Outdated
Show resolved
Hide resolved
4e735a3
to
69409d8
Compare
fb58587
to
2715b28
Compare
@@ -197,11 +236,12 @@ tests = | |||
prop_roundtrip_LEDGER_PredicateFails, | |||
testProperty "roundtrip Protocol State" prop_roundtrip_PrtclState, | |||
testProperty "roundtrip Ledger State" prop_roundtrip_LedgerState, | |||
testProperty "roundtrip NewEpoch State" prop_roundtrip_NewEpochState, | |||
-- testProperty "roundtrip NewEpoch State" prop_roundtrip_NewEpochState, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this is still commented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I uncommented, it passed, so a squashed everything into one commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up, it's looking great. One comment, otherwise happy to merge!
Added Data.Pulse to the semantics library, then Integrated pulsing into the reward calculation. Added prettyA and Arbitrary instances for the new data. Cleaned up Data.Coders and the Annotated combinators.
8a1d266
to
51fd21b
Compare
This is a better version of PR #2125