Add reqSignerHashes to Alonzo tx body #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhatisRT
approved these changes
Mar 25, 2021
|
LGTM |
JaredCorduan
commented
Mar 26, 2021
| @@ -224,6 +230,13 @@ alonzoStyleWitness = do | |||
| inputHashes = Set.fromList utxoHashes | |||
| txHashes == inputHashes ?! DataHashSetsDontAgree txHashes inputHashes | |||
|
|
|||
| let reqSignerHashes' = getField @"reqSignerHashes" txbody | |||
| witsKeyHashes = unWitHashes $ witsFromTxWitnesses @era tx | |||
| -- We are computing witsKeyHashes twice, here and in shelleyStyleWitness | |||
There was a problem hiding this comment.
actually we are not! make a comment that the hashes are cached.
And also validate it in the UTxOW rule. Additionally, rename all sdHash to wppHash
JaredCorduan
force-pushed
the
jc/reqSignerHashes
branch
from
93371a0
to
0fafcc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
reqSignerHashesto Alonzo tx body, and perform the corresponding validation in theUTxOWrule.additionally (and unrelated, but in a separate commit), consistently use the name
wppHashinstead ofsdHash(as per the new version of the spec).