Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to spec from discussions #2212

Merged
merged 4 commits into from
Apr 1, 2021
Merged

Updates to spec from discussions #2212

merged 4 commits into from
Apr 1, 2021

Conversation

polinavino
Copy link
Contributor

@polinavino polinavino commented Mar 31, 2021 •
edited
Loading

Main things :

  • build txInfo only once per Tx
  • add redundant check that scriptsNeeded has same number of elements as the collectNNScriptInputs output
  • fix indexedRedeemers
  • fix checkRedeemers

JaredCorduan
JaredCorduan approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@polinavino polinavino merged commit 2fa0a9c into master Apr 1, 2021
@iohk-bors iohk-bors bot deleted the polina/scripts-needed branch April 1, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@WhatisRT WhatisRT Awaiting requested review from WhatisRT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polinavino @JaredCorduan