Added deserialisation tests for length-of Plutus ByteStrings > 64. #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
approved these changes
Apr 1, 2021
TimSheard
force-pushed
the
ts-checkPlutusBytes-toolong
branch
from
df31ed1
to
2890d85
Compare
nc6
requested changes
Apr 12, 2021
TimSheard
force-pushed
the
ts-checkPlutusBytes-toolong
branch
from
97ba6e1
to
d76ebea
Compare
|
I cleaned this up, addressed the (Show(CompactAddr era)) comments from Nick, rebased on the most recent master. bench: Failed to decode state: DecoderErrorDeserialiseFailure "state" (DeserialiseFailure 6689 "expected integer") |
TimSheard
force-pushed
the
ts-checkPlutusBytes-toolong
branch
3 times, most recently
from
9e9a627
to
d85d952
Compare
In order to validate data in both AuxiliaryData and in the WitnessSet, deserializing a Plutus Data, with a ByteString type, whose length is greater than 64 now raises a deserialisation error. Added a new combinator (<?) to Data.Coders that lets any 'constructor' raise an error. Also added roundtrip tests to be sure we actually catch these cases. Before running plutus scripts, we collect their input data using their hashes and the Witnesses. Previous PredicateFailure tests should ensure we find Data for every script, BUT the consequences of not finding Data means scripts can get dropped, so things might validate that shouldn't. So we double check that every Script has its Data, and if that is not the case, a PredicateFailure is raised in the Utxos rule.
TimSheard
force-pushed
the
ts-checkPlutusBytes-toolong
branch
from
d85d952
to
319e97f
Compare
nc6
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to validate data in both AuxiliaryData and in the WitnessSet, deserializing
a Plutus Data, with a ByteString type, whose length is greater than 64 now raises
a deserialisation error. Added a new combinator (<?) to Data.Coders that lets any
'constructor' raise an error. Also added roundtrip tests to be sure we actually
catch these cases.