Alonzo Scripts cahnged to simple Sum type. #2221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to validate data in both AuxiliaryData and in the WitnessSet, deserializing a Plutus Data, with a ByteString type, whose length is greater than 64 now raises a deserialisation error. Added a new combinator (<?) to Data.Coders that lets any 'constructor' raise an error. Also added roundtrip tests to be sure we actually catch these cases.
Removed calls to error, because the method indexOf might fail. Also tracked down a few others. Also discovered that STS.ApplyTx hardcodes in Shelley Tx, rather than Core.Tx Relplace Tx with COre.Tx is its defintion in Shelley.Spec.Ledger.API.Mempool Still Having some trouble writing an ApplyTX for Alonzo.
The Scrit in the Alonzo era has been changed to a simpe Sum type with two constructors. This is possible because both variants store there original bytes, so the SafeToHash instance does not need a Memobytes to memoize the originalBytes. Also fixed up validting scripts, by using the Plutus side validateScript. this allowed the repository to not need the serialize or the flat packages, which were removed from the cabal file.
TimSheard
force-pushed
the
ts-script-nomemo
branch
from
7642714
to
212c0cf
Compare
nc6
requested changes
Apr 8, 2021
|
This PR has been superceeded by #2226 and will be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Script in the Alonzo era has been changed to a simple Sum type with two
constructors. This is possible because both variants store there original bytes,
so the SafeToHash instance does not need a Memobytes to memoize the originalBytes.
Also fixed up validating scripts, by using the Plutus side validateScript. this allowed
the repository to not need the serialize or the flat packages, which were removed
from the cabal file.