Drop Ord instances for ExUnits. #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Ord instance for ExUnits is problematic, since when we want to compare if one ExUnits is less than anther we want the partial pointwise ordering, not the lexigraphic ordering one gets when deriving Ord. Addresses CAD 2929 1) we drop the Ord instance for ExUnits 2) We provide a pointwise comparision pointWiseExUnits 3) We replace calls of (ex1 <= ex2) with (pointWiseExUnits (<=) ex1 ex2) 4) We roll an Ord instance of (PParams StrictMaybe era) by hand since its needs a lexographic ordering in ExUnits.
nc6
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses CAD 2929
The Ord instance for ExUnits is problematic, since when we want to compare
if one ExUnits is less than another we want the partial pointwise ordering,
not the lexigraphic ordering one gets when deriving Ord.
needs a lexographic ordering in ExUnits.