do not fold over range pt 2 #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 14, 2021 15:53
The preservation of ada property test discovered a bug, which can be recreated with: TASTY_PATTERN="Ada is preserved" cabal test \ cardano-ledger-shelley-ma-test --test-options "--quickcheck-replay=172459" This was, in fact, the same root problem fixed in 2dda291. I audited all other uses of the `range` function.
JaredCorduan
force-pushed
the
jc/do-not-fold-over-range-pt-2
branch
from
a087e21
to
55eb0cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was actually a second
foldover arangein theapplyRUpdfunction, ie the problem fixed in #2136 was manifest somewhere else. I've audited the code for all uses ofrange.This PR would be very tiny, except for the fact that I added a lot to the error message in the property test that found the problem.