Align spec with code #2243
Merged
Align spec with code #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some scratch notes about code which came up during review (PR with details about these to follow):
Word64 vs natural use
597 Params : Maybe (LangDepView era)
PlutusScript Script_plc
Datum/redeemer aliases
newset = mapMaybeSet (getLanguageView pp) langs — needs type signature
Match txbody field names and order!
Validity interval
Auxiliary data - script and metadata type mismatch
ValidatedTx vs Tx in spec?
Bootstrap witnesses, key witnesses - these are sets
feesOK - check that there are redeemers instead of non-0 ExUnits
Replace Val.inject (Val.coin with function
Txins is JUST txins like in Shelley, does not also include fee inputs - use ones defined in alonzo Tx, not Shelley
System time conversion check is not implemented
indexof ∈ PolicyID → Value → Ix takes set of PolicyIDs instead
txInfo doesn’t take Language, and is called transTx
collectNNScriptInputs order wrong
collectTwoPhaseScriptInputs should have noData error
evalScripts should only be for non native scripts
Check also validateScript
collectNNScriptInputs vs collectTwoPhaseScriptInputs why are they both there and different?
TODO add spec constants - network ID , system time, and epoch info
Move network id body check to UTXO
Add outputsAttrsTooBig to spec?