Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move txbody network ID check to UTxO rule #2254

Merged
merged 2 commits into from
Apr 25, 2021
Merged

move txbody network ID check to UTxO rule #2254

merged 2 commits into from
Apr 25, 2021

Conversation

JaredCorduan
Copy link
Contributor

@JaredCorduan JaredCorduan commented Apr 23, 2021 •
edited
Loading

This is consistent with the other network ID checks now, and also with the spec.

I've also fix one small unrelated thing, namely using the correct txins in Alonzo (separate commit).

move txbody network ID check to UTxO rule
98851fc 
This is consistent with the other nextwork ID checks now.
@JaredCorduan JaredCorduan mentioned this pull request Apr 23, 2021
Closed
Alonzo should use the Alonzo txins
39edbf4 
Which combines the two inputs lists
polinavino
polinavino approved these changes Apr 25, 2021
View reviewed changes
Copy link
Contributor

@polinavino polinavino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@polinavino polinavino merged commit b39bf86 into master Apr 25, 2021
@iohk-bors iohk-bors bot deleted the jc/move-txbody-network-id-check branch April 25, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polinavino polinavino polinavino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaredCorduan @polinavino