Added EraGen instance for Alonzo #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nc6
requested changes
Apr 29, 2021
shelley/chain-and-ledger/executable-spec/src/Cardano/Ledger/Shelley.hs
Outdated
Show resolved
Hide resolved
TimSheard
force-pushed
the
ts-EraGen-alonzo
branch
from
690562e
to
df9e1af
Compare
TimSheard
force-pushed
the
ts-EraGen-alonzo
branch
from
b1789bd
to
e00216f
Compare
|
This PR touches a lot of files, but the vast majority are only changing the types of functions that were over constrained to Shelley-like Eras. It adds instances so the Alonzo Era can now run the property tests. It added a bunch of missing PrettyA instances. |
nc6
requested changes
May 7, 2021
...ain-and-ledger/shelley-spec-ledger-test/src/Test/Shelley/Spec/Ledger/Generator/Delegation.hs
Show resolved
Hide resolved
TimSheard
force-pushed
the
ts-EraGen-alonzo
branch
from
98d2e02
to
704d8db
Compare
TimSheard
commented
May 7, 2021
...in-and-ledger/shelley-spec-ledger-test/src/Test/Shelley/Spec/Ledger/Generator/Trace/Chain.hs
Show resolved
Hide resolved
JaredCorduan
approved these changes
May 10, 2021
There was a problem hiding this comment.
Thank you @TimSheard for taking on this huge and unpleasant task!
TimSheard
force-pushed
the
ts-EraGen-alonzo
branch
2 times, most recently
from
d9fdf4d
to
dcac17e
Compare
redxaxder
force-pushed
the
ts-EraGen-alonzo
branch
4 times, most recently
from
1035d21
to
dadd59f
Compare
nc6
approved these changes
May 11, 2021
| @@ -185,7 +185,7 @@ data UtxoPredicateFailure era | |||
| | TriesToForgeADA | |||
| | -- | list of supplied bad transaction outputs | |||
| OutputTooBigUTxO | |||
| ![Core.TxOut era] | |||
| ![(Int, Int, Core.TxOut era)] | |||
There was a problem hiding this comment.
Should label in haddock what these parameters mean
Introduce the class (EraGen era) which provides Era specific code such that modules like ClassifyTraces and TestChain work over the Core.XXX type families. The EraGen class has a bunch of super classes which every instance should meet. Added instances for Shelley, Allegra, Mary Alonzo, and Example. Renamed the files which make EraGen instances to XXXEraGen, so naming is consistent. Made a better someLeaf function for Alonzo era Made sure the PParams costModel can't not be empty. It must have entry for PlutusV1. Made sure that the _d PParam cannot be 0 in Alonzo (leads to deadlock) Still to do, add better Shrinkers (can we add EraGen parametric ones?)
JaredCorduan
force-pushed
the
ts-EraGen-alonzo
branch
from
d4bc813
to
a555605
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aded an EraGen instance for Alonzo in the Tests: Test.Cardano.Ledger.Alonzo.EraGenInstance
I had to generalize the EraGen class slightly to make an Alonzo instance adding the method genEraPParamsDelta
because the type family PParamsDelta is different in Alonzo than in earlier Eras.
I had to export a few functions in a few files where they were no exported before, because they were needed in the Alonzo instance. Made few other small changes to a number of files.