Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement applyTx for Alonzo #2264

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Implement applyTx for Alonzo #2264

merged 3 commits into from
Apr 30, 2021

Conversation

nc6
Copy link
Contributor

@nc6 nc6 commented Apr 29, 2021 •
edited
Loading

This PR jointly written with @TimSheard.

  • Some functions are generalised to operate over both TxInBlock and Tx.
  • Some internals from small-steps are exposed in order to allow running rules outside of the STS context.
  • We add functions to compute the validated TxInBlock from the raw Tx, and expose this in the API.

@nc6 nc6 requested a review from JaredCorduan April 29, 2021 08:03
JaredCorduan
JaredCorduan approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Seems you just need ormolu to pass CI now.

TimSheard and others added 3 commits April 30, 2021 13:16
@TimSheard @nc6
Made functions take (tx) rather than Tx.
0708505
@nc6
Add 'constructValidated' function.
6225c9f 
This required the export of some internal bits from the STS machinery in
order to allow running rules independently of the STS.
@TimSheard @nc6
Implement 'validateTx' for Mempool API.
b8617a3
@nc6 nc6 force-pushed the ts-new-mempool-onTopOf-nick branch from 85a7007 to b8617a3 Compare April 30, 2021 11:16
@nc6 nc6 mentioned this pull request Apr 30, 2021
Merged
@nc6 nc6 merged commit 73e1ca7 into master Apr 30, 2021
@iohk-bors iohk-bors bot deleted the ts-new-mempool-onTopOf-nick branch April 30, 2021 11:58
@JaredCorduan JaredCorduan mentioned this pull request May 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nc6 @JaredCorduan @TimSheard