Collateral inputs #2273
Merged
Collateral inputs #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polinavino
reviewed
May 6, 2021
| eval (Alonzo.txins @era txb ⊆ dom utxo) | ||
| ?! BadInputsUTxO (eval (Alonzo.txins @era txb ➖ dom utxo)) | ||
| eval (inputsAndCollateral ⊆ dom utxo) | ||
| ?! BadInputsUTxO (eval (inputsAndCollateral ➖ dom utxo)) |
There was a problem hiding this comment.
i missed this check! important : )
There was a problem hiding this comment.
the change I made to witsVKeyNeeded was to include the collateral inputs in the set of keys that require signatures, so that signatures are checked for inputsAndCollateral not just inputs
I changed the function to have 2 additional things, that ^^ and reqSignerHashes to avoid the awkward union in the UTXOW rule of the stuff in the Shelley witsVKeyNeeded function and the two additional things
redxaxder
approved these changes
May 6, 2021
|
Thanks for fixing the examples, @JaredCorduan! I'll rebase this on master since it seems to have become outdated. |
This should correspond to the changes made to the spec in #2271. - Fee inputs have now been dropped. Fees may be paid from any TxOut, including Plutus script addresses, and are included in the main inputs as with all previous eras. - Instead, we have "collateral" which must be posted with transactions spending from script addresses. This collateral is only collected if a script fails to validate (e.g. a second phase validation). This collateral must be provided by VKey-locked inputs. - Two new protocol parameters govern this: - The collateral percentage determins the percentage of the fee which must be posted as collateral. - The max collateral inputs determines the maximum number of inputs which must be posted as collateral. - The CDDL is now updated in order to reflect that inputs remain at key '0'. This is OK because collateral is only required for Plutus locked addresses. The limit on the number of collateral inputs, and the restriction to VKey addresses, is done in order to bound the amount of work which may be involved in verifying collateral.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should correspond to the changes made to the spec in #2271.
including Plutus script addresses, and are included in the main inputs
as with all previous eras.
spending from script addresses. This collateral is only collected if a
script fails to validate (e.g. a second phase validation). This
collateral must be provided by VKey-locked inputs.
must be posted as collateral.
which must be posted as collateral.
'0'. This is OK because collateral is only required for Plutus locked
addresses.
The limit on the number of collateral inputs, and the restriction to
VKey addresses, is done in order to bound the amount of work which may
be involved in verifying collateral.