Check that collateral inputs must be signed #2277
Conversation
This brings the code into line with the updated spec, which overrides this function. It also addresses CAD-2937, and ensures that signers must be present for all collateral inputs.
| GenDelegs (Crypto era) -> | ||
| WitHashes (Crypto era) | ||
| witsVKeyNeeded utxo' tx genDelegs = | ||
| WitHashes $ |
There was a problem hiding this comment.
Is there a reason you defined witsVKeyNeeded from scratch, rather than unioning the collateral input key set with the Shelley definition of witsVKeyNeeded?
There was a problem hiding this comment.
My policy here has always been to follow the spec, in order to make it easier to check we're doing the same thing. In this case, the spec overrides the whole witsVKeyNeeded function, so I did the same.
That having been said, I'm totally fine with doing this in a different way.
There was a problem hiding this comment.
That is a good policy. It is indeed that way in the spec, but only because I thought it would be weird to either rename the function to something else or to say something like ShelleyMA.witsVKeyNeeded in the spec. Do you think that is a better idea to rename it to a new function, and do it that way in both code and spec?
There was a problem hiding this comment.
I am fine leaving it as is now, too
Note that this also changes the `validatingTxBody` in order to remove the required signers. These were not part of any existing test, and removing them allowed me to reuse this body in the collateral test.
This PR overrides the
witsVKeyNeededfunction in Alonzo, in line with the updated Alonzo spec.