Adding some instances needed for consensus. #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfrisby
approved these changes
May 13, 2021
| @@ -73,6 +73,8 @@ instance CryptoClass.Crypto c => UsesTxOut (ShelleyEra c) where | |||
| instance CryptoClass.Crypto c => UsesPParams (ShelleyEra c) where | |||
| mergePPUpdates _ = updatePParams | |||
|
|
|||
| type instance E.TranslationContext (ShelleyEra c) = () | |||
There was a problem hiding this comment.
This is somewhat questionable, since we never actually use TranslationContext for ShelleyEra. But that's also the reason that it's harmless. And it currently simplifies Consensus. Also, it's arguably more consistent: every era within the Shelley mega-era now has a TranslationContext instance. (Which is trivial prior to Alonzo.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These instances necessary for integration with consensus because the era's translation context is stored in the
LedgerConfig.